feat(pulse-sdk-solidity): Create Pulse solidity SDK #2667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tejasbadadare
commented
May 8, 2025
Comment on lines
+51
to
+52
| // We can still generate ABIs with warnings, only throw for errors | ||
| const errors = output.errors.filter((e) => e.severity === "error"); |
There was a problem hiding this comment.
FYI i excluded warnings due to this warning in PythAggregatorV3.sol blocking the precommit for the Pulse SDK. Turns out there is no simple way to disable solc warnings for a single line/file 🙃
We should enforce warnings somewhere else anyway, probably turbo test:lint and/or CI
ali-bahjati
approved these changes
May 12, 2025
There was a problem hiding this comment.
I recommend you add the signatures for these as well. (you can use cast sig)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Schedulercontract implements theISchedulerinterface from the SDK.abi_generatorscript to handle non-path importsRationale
This makes it possible for other services and contracts to easily interact with the Pulse protocol and consume its ABIs.
How has this been tested?
Will manually test installing and using the package from NPM after this gets merged and published. Locally installing and using the SDK in contracts works fine.